Deduplicate editables during install commands #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Apr 4, 2024
crates/uv/tests/pip_compile.rs
Outdated
Comment on lines
3105
to
3107
| -e file://../../scripts/packages/black_editable | ||
| -e file://../../scripts/packages/black_editable | ||
| -e file://../../scripts/packages/black_editable[dev] |
There was a problem hiding this comment.
Can you add test coverage for an absolute path that resolves to the same as a relative path?
Should we add handling for symbolic links?
There was a problem hiding this comment.
I'd prefer not to merge symlinks here, but I can add an absolute path test, yes.
There was a problem hiding this comment.
I mean, we could merge symlinks, it's not difficult, I'm just not sure if it's correct. I guess in theory they must resolve to the same package, so maybe it's totally fine...
charliermarsh
force-pushed
the
charlie/dupe
branch
from
5450946
to
8f28319
Compare
zanieb
approved these changes
Apr 4, 2024
|
Absolutely sublime🥇. Thanks for thinking about extra's as well. That's actually something we use and I forgot to mention it in the initial report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2819.