Add a --require-hashes command-line setting
#2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
enhancement
charliermarsh
force-pushed
the
charlie/check-hashes
branch
2 times, most recently
from
ec16897
to
b626db8
Compare
charliermarsh
force-pushed
the
charlie/check-hashes
branch
from
b626db8
to
525ed8a
Compare
konstin
approved these changes
Apr 10, 2024
| /// must either be pinned to exact versions (e.g., `==1.0.0`), or be specified via direct URL. | ||
| /// | ||
| /// Hash-checking mode introduces a number of additional constraints: | ||
| /// - Git dependencies are not supported. |
There was a problem hiding this comment.
Can we require a full length hash for git, or is that just a follow up PR?
There was a problem hiding this comment.
We could but pip doesn't support these so I was hesitant to deviate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'll likely only merge this once the PR chain is further along, but this PR wires up the setting fro the CLI.