Add ticks around error messages more consistently #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
approved these changes
Apr 12, 2024
|
Style-wise my favorite would be any quotes (backticks count) and no colon |
charliermarsh
force-pushed
the
charlie/ticks
branch
from
5784b9a
to
3487fcc
Compare
charliermarsh
force-pushed
the
charlie/ticks
branch
from
3487fcc
to
0ea4317
Compare
konstin
added a commit
that referenced
this pull request
Apr 23, 2024
Mostly a small refactor, adds backticks to be coherent with #3004.
konstin
added a commit
that referenced
this pull request
Apr 23, 2024
Mostly a small refactor, adds backticks to be coherent with #3004.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found some of these too bare (e.g., when they just show a package name with no other information). For me, this makes it easier to differentiate error message copy from data. But open to other opinions. Take a look at the fixture changes and LMK!