Allow uv run to execute Python scripts directly
#3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
added
internal
zanieb
commented
Apr 17, 2024
Comment on lines
-1350
to
+1636
| pub(crate) args: Vec<String>, | ||
| pub(crate) args: Vec<OsString>, |
There was a problem hiding this comment.
We need this to insert a properly insert a path into the arguments, but this seems generally "more correct".
We'll want to do this for target too.
zanieb
force-pushed
the
zb/uv-run-script
branch
from
7c2da6f
to
9d0dc77
Compare
zanieb
commented
Apr 17, 2024
| .map_or(false, |ext| ext.eq_ignore_ascii_case("py")) | ||
| && target_path.exists() | ||
| { | ||
| args.insert(0, target_path.as_os_str().into()); |
There was a problem hiding this comment.
I guess this is vaguely not performant but not meaningful?
zanieb
force-pushed
the
zb/uv-run-python
branch
from
db9246f
to
6f82f21
Compare
zanieb
force-pushed
the
zb/uv-run-script
branch
from
9d0dc77
to
0540743
Compare
zanieb
force-pushed
the
zb/uv-run-script
branch
from
0540743
to
3de9f35
Compare
e.g. `uv run foo.py` implies `python foo.py`
zanieb
force-pushed
the
zb/uv-run-script
branch
from
3de9f35
to
981b9c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
uv run foo.pyimpliespython foo.pyFuture work includes #3096