List and uninstall legacy editables #3396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I think this got closed because my upstream branch got deleted, maybe? |
|
Are you able to reopen? I'm fine with supporting this! |
| ))?; | ||
| let easy_install = site_package.join("easy-install.pth"); | ||
|
|
||
| // Note concurrent use of `easy-install.pth` may result in lost writes |
There was a problem hiding this comment.
This is my only concern. We might want to use an advisory file-lock on easy-install.pth? Or, actually, we could even use a mutex? Since we already have a lock on the environment itself, so in theory we only need to lock within this process.
|
Couldn't re-open, needed to make a new PR! #3415 I added a mutex, but lmk if I should do flock stuff instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No worries if this isn't something uv wants to support! Note this PR is currently based on top of #3380 , so shouldn't be merged till that one is merged