Apply normcase to line from easy-install.pth #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
commented
May 8, 2024
| let target_line = if cfg!(windows) { | ||
| // Do the equivalent of os.path.normcase | ||
| // This comes from `pkg_resources.normalize_path` | ||
| target_line.replace("\\", "/").to_lowercase() |
There was a problem hiding this comment.
Just going off of the non winapi version of https://github.com/python/cpython/blob/a7711a2a4e5cf16b34fc284085da724a8c2c06dd/Lib/ntpath.py#L78
Thanks for the suggestion from astral-sh#3415 (comment) Also it looks like you improved `egg-link` parsing in astral-sh@e23c91f so copying the changes over to the other parse site
|
(draft to make sure tests fail on windows before I fix things) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the suggestion from #3415 (comment)
Also it looks like you improved
egg-linkparsing in e23c91f so copying the changes over to the other parse site (happy to move this to a helper too, if so lmk where to put it)