Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JSON Schema and add export script #3461

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

A few errors I noticed after generating the schema.

@charliermarsh charliermarsh added the configuration Settings and such label May 8, 2024
@charliermarsh charliermarsh force-pushed the charlie/schema branch 2 times, most recently from 02db54f to a67079f Compare May 8, 2024 15:44
Comment on lines 18 to 19
root = Path(
check_output(["git", "rev-parse", "--show-toplevel"], text=True).strip(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor preference not to run a subprocess outside of main()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is copied over from Ruff, but I shall change!)

@charliermarsh charliermarsh force-pushed the charlie/schema branch 2 times, most recently from a0961d2 to b3e2943 Compare May 8, 2024 15:59
@charliermarsh charliermarsh enabled auto-merge (squash) May 8, 2024 16:01
@charliermarsh charliermarsh merged commit 7c66321 into main May 8, 2024
43 checks passed
@charliermarsh charliermarsh deleted the charlie/schema branch May 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Settings and such
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants