Fix install_registry_source_dist_cached on Gentoo #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increment the removed file counts in filters in install_registry_source_dist_cached test, to make it work again on Gentoo. The tested counts were updated in 9a92a3a, but the filters were not. That said, the respective count increased in Gentoo as well, so adjust both input and output strings. I'm updating Windows as a guesswork, though I suspect that filter may not be necessary anymore, given that CI was passing.
charliermarsh
approved these changes
May 14, 2024
|
Thank you so much, I'm sorry about that. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increment the removed file counts in filters
in install_registry_source_dist_cached test, to make it work again on Gentoo. The tested counts were updated
in 9a92a3a, but the filters were not. That said, the respective count increased in Gentoo as well, so adjust both input and output strings. I'm updating Windows as a guesswork, though I suspect that filter may not be necessary anymore, given that CI was passing.
Test Plan
cargo teston Gentoo :-).