Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create lib64 symlink for 64-bit, non-macOS, POSIX environments #3584

Merged
merged 3 commits into from
May 14, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented May 14, 2024

Summary

Closes #3578 (comment).

Test Plan

Verified that in the OpenSUSE test, we create both, and they're symlinks:

INFO: Creating virtual environment with `venv`...
INFO: Installing into `venv` virtual environment...
DEBUG Found a virtualenv named .venv at: /tmp/tmp4nape29h/.venv
DEBUG Cached interpreter info for Python 3.10.14, skipping probing: .venv/bin/python
DEBUG Using Python 3.10.14 environment at .venv/bin/python
DEBUG Trying to lock if free: .venv/.lock
purelib: "/tmp/tmp4nape29h/.venv/lib/python3.10/site-packages"
platlib: "/tmp/tmp4nape29h/.venv/lib64/python3.10/site-packages"
is_same_file(purelib, platlib): Ok(true)

@charliermarsh charliermarsh marked this pull request as ready for review May 14, 2024 17:47
@charliermarsh charliermarsh added bug Something isn't working compatibility Compatibility with a specification or another tool labels May 14, 2024
@konstin
Copy link
Member

konstin commented May 14, 2024

Code lgtm but it's odd because virtualenv doesn't create this directory for me

@charliermarsh
Copy link
Member Author

Would you vote against merging? I tend to view venv as the reference implementation but also agree it's strange.

@konstin
Copy link
Member

konstin commented May 14, 2024

The extra directory wont hurt, but it would be good to understand what virtualenv does here

@charliermarsh
Copy link
Member Author

@gaborbernat - sorry to bother, have you seen this before?

@gaborbernat
Copy link
Contributor

Could be bug, I know Fedora creates two folders and should work.

@charliermarsh charliermarsh merged commit 30a7475 into main May 14, 2024
44 checks passed
@charliermarsh charliermarsh deleted the charlie/syslink branch May 14, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Compatibility with a specification or another tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv venv does not create a lib64 directory
3 participants