Add UV_CONCURRENT_INSTALLS variable in favor of RAYON_NUM_THREADS
#3646
Conversation
|
Are we always going to use a single global thread pool? I guess... |
|
It seems like an implementation detail though. If, in the future, we use Rayon elsewhere, we may in fact want to use different pool sizes for different tasks -- or is that wrong? |
|
Yeah. For example we run some other file operations on tokios blocking pool. I think worker threads is a bit misleading because we already have download and build limits. |
|
I think the current name is ok... |
| @@ -583,8 +585,6 @@ In addition, uv respects the following environment variables: | |||
| - `FISH_VERSION`: Used to detect the use of the Fish shell. | |||
| - `BASH_VERSION`: Used to detect the use of the Bash shell. | |||
| - `ZSH_VERSION`: Used to detect the use of the Zsh shell. | |||
| - `RAYON_NUM_THREADS`: Used to control the number of threads used when unzipping and installing | |||
| packages. See the [rayon documentation](https://docs.rs/rayon/latest/rayon/) for more. | |||
There was a problem hiding this comment.
Does this no longer have any effect? (If it still has an effect, we should leave it here, even if UV_CONCURRENT_INSTALLS is recommended, since this is intended to document env variables that could affect behavior.)
There was a problem hiding this comment.
It shouldn't have any effect because we're initialize the global thread pool manually.
| // The default concurrent builds limit. | ||
| pub fn default_builds() -> usize { | ||
| // The default concurrent builds and install limit. | ||
| pub fn threads() -> usize { |
There was a problem hiding this comment.
Just confirming that this is the same as the Rayon default?
There was a problem hiding this comment.
Summary
Continuation of #3493. This gives us more flexibility in case we decide to move away from
rayonin the future.Should this be named something else? We also use
rayonfor unzipping files, and maybe other things in the future?