Support editables in uv sync
#3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is bare-bones support for editables in `uv run` as basis for workspace support. It leverages the existing `ResolvedEditables` infrastructure.
| // TODO(konsti): Read editables from lockfile. | ||
| let editables = ResolvedEditables::default(); | ||
| let editables = ResolvedEditables::resolve( | ||
| Vec::new(), // TODO(konsti): Read editables from lockfile |
There was a problem hiding this comment.
Wait, but this PR doesn't actually add anything, does it?
There was a problem hiding this comment.
I intentionally removed this in favor of a default impl.
There was a problem hiding this comment.
I see, i'll revert it until we have editable from the lockfile then: #3696
konstin
added a commit
that referenced
this pull request
May 21, 2024
charliermarsh
pushed a commit
that referenced
this pull request
May 21, 2024
charliermarsh
pushed a commit
that referenced
this pull request
May 21, 2024
charliermarsh
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bare-bones support for editables in
uv syncas basis for workspace support, notably without lockfile integration. It leverages the existingResolvedEditablesinfrastructure.