Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not discover virtual environment interpreters in uv venv --python ... #3728

Merged
merged 1 commit into from
May 22, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented May 21, 2024

Otherwise uv venv --python 3.12 can prefer .venv/bin/python over the system Python (which is always used if you don't provide a --python flag). I would find this confusing as a user.

@zanieb zanieb added the bug Something isn't working label May 21, 2024
@zanieb zanieb force-pushed the zb/venv-no-venv branch 2 times, most recently from a190289 to c1b4fbe Compare May 22, 2024 00:12
@zanieb
Copy link
Member Author

zanieb commented May 22, 2024

I tried to write a test for this but it wasn't feasible 🤷‍♀️

Looked like a190289 — didn't catch a regression.

@zanieb zanieb marked this pull request as ready for review May 22, 2024 00:14
@zanieb zanieb requested a review from charliermarsh May 22, 2024 00:14
@zanieb zanieb merged commit becdc64 into main May 22, 2024
89 checks passed
@zanieb zanieb deleted the zb/venv-no-venv branch May 22, 2024 01:00
@zanieb zanieb added the internal A refactor or improvement that is not user-facing label May 22, 2024
@zanieb
Copy link
Member Author

zanieb commented May 22, 2024

Omitting from the changelog since it's unreleased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants