Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aarch64-unknown-linux-gnu from list of expected binaries #3761

Merged
merged 1 commit into from
May 22, 2024
Merged

Remove aarch64-unknown-linux-gnu from list of expected binaries #3761

merged 1 commit into from
May 22, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented May 22, 2024 •
edited
Loading

Summary

We now only ship the static aarch64-unknown-linux-musl binary here.

Closes #3760.

@charliermarsh charliermarsh added bug Something isn't working releases Related to building and distributing release artifacts of uv labels May 22, 2024
zanieb
zanieb approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 👀 👀 👀

@charliermarsh charliermarsh enabled auto-merge (squash) May 22, 2024 19:37
@charliermarsh
Copy link
Member Author

Ok, confirmed that the installer does fall back:

    # Lookup what to download/unpack based on platform
    case "$_arch" in 
        "aarch64-apple-darwin")
            _artifact_name="uv-aarch64-apple-darwin.tar.gz"
            _zip_ext=".tar.gz"
            _bins="uv"
            _bins_js_array='"uv"'
            _updater_name=""
            _updater_bin=""
            ;;
        "aarch64-unknown-linux-gnu")
            _artifact_name="uv-aarch64-unknown-linux-musl.tar.gz"
            _zip_ext=".tar.gz"
            _bins="uv"
            _bins_js_array='"uv"'
            _updater_name=""
            _updater_bin=""
            ;;
        "aarch64-unknown-linux-musl-dynamic")
            _artifact_name="uv-aarch64-unknown-linux-musl.tar.gz"
            _zip_ext=".tar.gz"
            _bins="uv"
            _bins_js_array='"uv"'
            _updater_name=""
            _updater_bin=""
            ;;
        "aarch64-unknown-linux-musl-static")
            _artifact_name="uv-aarch64-unknown-linux-musl.tar.gz"
            _zip_ext=".tar.gz"
            _bins="uv"
            _bins_js_array='"uv"'
            _updater_name=""
            _updater_bin=""
            ;;

By running cargo dist build -aglobal.

@charliermarsh charliermarsh merged commit be81eee into main May 22, 2024
44 checks passed
@charliermarsh charliermarsh deleted the charlie/gnu branch May 22, 2024 23:53
@charliermarsh charliermarsh mentioned this pull request May 22, 2024
Merged
charliermarsh added a commit that referenced this pull request May 23, 2024
@charliermarsh
Revert "Revert "ci: drop native manylinux wheel for dual-tagged one (#…
bb61c2d 
…3685)" (#3762)" (#3778)

Now that we have #3761, it should be
safe to drop these.
@konstin
Copy link
Member

konstin commented May 23, 2024

Thanks for checking & fixing!

@BrewTestBot BrewTestBot mentioned this pull request May 24, 2024
Merged
@andriygm andriygm mentioned this pull request May 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working releases Related to building and distributing release artifacts of uv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UV 2.0 installation fails on aarch64-unknown-linux-gnu (inside docker basically)
3 participants
@charliermarsh @konstin @zanieb