Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support x86 windows #3873

Merged
merged 3 commits into from
May 28, 2024
Merged

Support x86 windows #3873

merged 3 commits into from
May 28, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented May 28, 2024

Add trampolines for x86 windows.

Closes #3660.

@konstin konstin added enhancement New feature or request windows Specific to the Windows platform labels May 28, 2024
Copy link

codspeed-hq bot commented May 28, 2024

CodSpeed Performance Report

Merging #3873 will not alter performance

Comparing konsti/x86 (e611ebb) with main (cedd18e)

Summary

✅ 13 untouched benchmarks

@konstin
Copy link
Member Author

konstin commented May 28, 2024

I've confirmed that this works with portable 32-bit python 3.12 and an i686-pc-windows-msvc build, though on a 64-bit windows.

@konstin konstin marked this pull request as ready for review May 28, 2024 10:45
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to update the UnsupportedWindowsArch message.

@charliermarsh charliermarsh enabled auto-merge (squash) May 28, 2024 16:01
@charliermarsh charliermarsh merged commit f924477 into main May 28, 2024
46 checks passed
@charliermarsh charliermarsh deleted the konsti/x86 branch May 28, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request windows Specific to the Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Unable to create Windows launch for x86' while installing packages
2 participants