Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use universal resolution in uv lock #3969

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Use universal resolution in uv lock #3969

merged 1 commit into from
Jun 3, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Wires up the optional markers in resolution, and adds respecting-the-markers to Lock:: to_resolution.

@charliermarsh charliermarsh added the preview Experimental behavior label Jun 3, 2024
@charliermarsh charliermarsh marked this pull request as ready for review June 3, 2024 00:07
Copy link

codspeed-hq bot commented Jun 3, 2024

CodSpeed Performance Report

Merging #3969 will improve performances by 6.72%

Comparing charlie/glob (61c9d70) with main (c500b78)

Summary

⚡ 1 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main charlie/glob Change
wheelname_tag_compatibility[flyte-short-incompatible] 926.7 ns 868.3 ns +6.72%

@charliermarsh charliermarsh force-pushed the charlie/glob branch 4 times, most recently from cead01c to 07d3df7 Compare June 3, 2024 01:23
@charliermarsh charliermarsh merged commit a23ca5b into main Jun 3, 2024
46 checks passed
@charliermarsh charliermarsh deleted the charlie/glob branch June 3, 2024 01:33
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this all makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants