Respect Requires-Python in universal resolution
#3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/req-python
branch
2 times, most recently
from
ab5834d
to
823f9a1
Compare
charliermarsh
force-pushed
the
charlie/req-python
branch
from
823f9a1
to
c62267b
Compare
charliermarsh
force-pushed
the
charlie/req-python
branch
from
c62267b
to
a45ef53
Compare
charliermarsh
force-pushed
the
charlie/req-python
branch
5 times, most recently
from
7b4b18b
to
cd1fb38
Compare
charliermarsh
commented
Jun 3, 2024
| ----- stderr ----- | ||
| warning: `uv lock` is experimental and may change without warning. | ||
| × No solution found when resolving dependencies: | ||
| ╰─▶ Because the requested Python version (>=3.7) does not satisfy Python>=3.8 and the requested Python version (>=3.7) does not satisfy Python>=3.7.9,<3.8, we can conclude that Python>=3.7.9 are incompatible. |
There was a problem hiding this comment.
Not a particularly clear message but it's roughly the same as echo "pygls>=1.1.0" | cargo run pip compile --python-version 3.7 - before any of my changes.
There was a problem hiding this comment.
Here's Poetry:
The current project's Python requirement (>=3.7) is not compatible with some of the required packages Python requirement:
- pygls requires Python >=3.7.9,<4, so it will not be satisfied for Python >=3.7,<3.7.9 || >=4
- pygls requires Python >=3.7.9,<4, so it will not be satisfied for Python >=3.7,<3.7.9 || >=4
- pygls requires Python >=3.7.9,<4, so it will not be satisfied for Python >=3.7,<3.7.9 || >=4
- pygls requires Python >=3.7.9,<4, so it will not be satisfied for Python >=3.7,<3.7.9 || >=4
- pygls requires Python >=3.7.9,<4, so it will not be satisfied for Python >=3.7,<3.7.9 || >=4
- pygls requires Python >=3.8, so it will not be satisfied for Python >=3.7,<3.8
- pygls requires Python >=3.8, so it will not be satisfied for Python >=3.7,<3.8
Because no versions of pygls match >1.1.0,<1.1.1 || >1.1.1,<1.1.2 || >1.1.2,<1.2.0 || >1.2.0,<1.2.1 || >1.2.1,<1.3.0 || >1.3.0,<1.3.1 || >1.3.1
and pygls (1.1.0) requires Python >=3.7.9,<4, pygls is forbidden.
And because pygls (1.1.1) requires Python >=3.7.9,<4, pygls is forbidden.
And because pygls (1.1.2) requires Python >=3.7.9,<4
and pygls (1.2.0) requires Python >=3.7.9,<4, pygls is forbidden.
And because pygls (1.2.1) requires Python >=3.7.9,<4
and pygls (1.3.0) requires Python >=3.8, pygls is forbidden.
So, because pygls (1.3.1) requires Python >=3.8
and poetry-test depends on pygls (>=1.1.0), version solving failed.
• Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties
For pygls, a possible solution would be to set the `python` property to ">=3.7.9,<4"
For pygls, a possible solution would be to set the `python` property to ">=3.7.9,<4"
For pygls, a possible solution would be to set the `python` property to ">=3.7.9,<4"
For pygls, a possible solution would be to set the `python` property to ">=3.7.9,<4"
For pygls, a possible solution would be to set the `python` property to ">=3.7.9,<4"
For pygls, a possible solution would be to set the `python` property to ">=3.8"
For pygls, a possible solution would be to set the `python` property to ">=3.8"
There was a problem hiding this comment.
We should add a hint here that "requested Python version" refers to the version you declared in your pyproject.toml and that - unlike everything else - that version needs to stricter than the one in your dependencies.
There was a problem hiding this comment.
Will do in a separate PR.
konstin
approved these changes
Jun 4, 2024
| match self { | ||
| RequiresPython::Specifier(specifier) => requires_python.contains(specifier), | ||
| RequiresPython::Specifiers(specifiers) => { | ||
| let Ok(target) = specifiers |
There was a problem hiding this comment.
Added the missing try_from conversion method for that in #4010
| ----- stderr ----- | ||
| warning: `uv lock` is experimental and may change without warning. | ||
| × No solution found when resolving dependencies: | ||
| ╰─▶ Because the requested Python version (>=3.7) does not satisfy Python>=3.8 and the requested Python version (>=3.7) does not satisfy Python>=3.7.9,<3.8, we can conclude that Python>=3.7.9 are incompatible. |
There was a problem hiding this comment.
We should add a hint here that "requested Python version" refers to the version you declared in your pyproject.toml and that - unlike everything else - that version needs to stricter than the one in your dependencies.
charliermarsh
force-pushed
the
charlie/req-python
branch
from
cd1fb38
to
6c0f76e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3982.