Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect existing .egg-info files in site packages #4082

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jun 6, 2024

Summary

As with other .egg-info and .egg-link distributions, it's easy to support existing .egg-info files. Like pip, we refuse to uninstall these, since there's no way to know which files are part of the distribution.

Closes #4059.

Test Plan

Verify that vtk is included here, which is installed as a .egg-link file:

> conda create -c conda-forge -n uv-test python h5py vtk pyside6 cftime psutil

> cargo run pip freeze --python /opt/homebrew/Caskroom/miniforge/base/envs/uv-test/bin/python
aiohttp @ file:///Users/runner/miniforge3/conda-bld/aiohttp_1713964997382/work
aiosignal @ file:///home/conda/feedstock_root/build_artifacts/aiosignal_1667935791922/work
attrs @ file:///home/conda/feedstock_root/build_artifacts/attrs_1704011227531/work
cached-property @ file:///home/conda/feedstock_root/build_artifacts/cached_property_1615209429212/work
cftime @ file:///Users/runner/miniforge3/conda-bld/cftime_1715919201099/work
frozenlist @ file:///Users/runner/miniforge3/conda-bld/frozenlist_1702645558715/work
h5py @ file:///Users/runner/miniforge3/conda-bld/h5py_1715968397721/work
idna @ file:///home/conda/feedstock_root/build_artifacts/idna_1713279365350/work
loguru @ file:///Users/runner/miniforge3/conda-bld/loguru_1695547410953/work
msgpack @ file:///Users/runner/miniforge3/conda-bld/msgpack-python_1715670632250/work
multidict @ file:///Users/runner/miniforge3/conda-bld/multidict_1707040780513/work
numpy @ file:///Users/runner/miniforge3/conda-bld/numpy_1707225421156/work/dist/numpy-1.26.4-cp312-cp312-macosx_11_0_arm64.whl
pip==24.0
psutil @ file:///Users/runner/miniforge3/conda-bld/psutil_1705722460205/work
pyside6==6.7.1
setuptools==70.0.0
shiboken6==6.7.1
vtk==9.2.6
wheel==0.43.0
wslink @ file:///home/conda/feedstock_root/build_artifacts/wslink_1716591560747/work
yarl @ file:///Users/runner/miniforge3/conda-bld/yarl_1705508643525/work

@charliermarsh charliermarsh added the compatibility Compatibility with a specification or another tool label Jun 6, 2024
@charliermarsh charliermarsh marked this pull request as ready for review June 6, 2024 00:54
@charliermarsh charliermarsh enabled auto-merge (squash) June 6, 2024 00:55
@charliermarsh charliermarsh merged commit a81fb92 into main Jun 6, 2024
46 checks passed
@charliermarsh charliermarsh deleted the charlie/egg-link branch June 6, 2024 01:00
@charliermarsh charliermarsh changed the title Respect existing .egg-link files in site packages Respect existing .egg-info files in site packages Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility with a specification or another tool
Projects
None yet
1 participant