Refactor uv-toolchain types
#4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/toolchain-iii
branch
3 times, most recently
from
448b1b5 to
a3d1e00
Compare
zanieb
force-pushed
the
zb/toolchain-iii
branch
2 times, most recently
from
162f821 to
a5ad118
Compare
This was referenced Jun 7, 2024
zanieb
added a commit
that referenced
this pull request
Jun 7, 2024
# Conflicts: # crates/uv/src/commands/pip/sync.rs # crates/uv/src/commands/pip/uninstall.rs # crates/uv/src/commands/project/lock.rs
# Conflicts: # crates/uv-toolchain/src/environment.rs
charliermarsh
approved these changes
Jun 7, 2024
zanieb
added a commit
that referenced
this pull request
Jun 7, 2024
zanieb
added a commit
that referenced
this pull request
Jun 10, 2024
…4138) Extends #4121 Part of #2607 Adds support for managed toolchain fetching to `uv venv`, e.g. ``` ❯ cargo run -q -- venv --python 3.9.18 --preview -v DEBUG Searching for Python 3.9.18 in search path or managed toolchains DEBUG Searching for managed toolchains at `/Users/zb/Library/Application Support/uv/toolchains` DEBUG Found CPython 3.12.3 at `/opt/homebrew/bin/python3` (search path) DEBUG Found CPython 3.9.6 at `/usr/bin/python3` (search path) DEBUG Found CPython 3.12.3 at `/opt/homebrew/bin/python3` (search path) DEBUG Requested Python not found, checking for available download... DEBUG Using registry request timeout of 30s INFO Fetching requested toolchain... DEBUG Downloading https://github.com/indygreg/python-build-standalone/releases/download/20240224/cpython-3.9.18%2B20240224-aarch64-apple-darwin-pgo%2Blto-full.tar.zst to temporary location /Users/zb/Library/Application Support/uv/toolchains/.tmpgohKwp DEBUG Extracting cpython-3.9.18%2B20240224-aarch64-apple-darwin-pgo%2Blto-full.tar.zst DEBUG Moving /Users/zb/Library/Application Support/uv/toolchains/.tmpgohKwp/python to /Users/zb/Library/Application Support/uv/toolchains/cpython-3.9.18-macos-aarch64-none Using Python 3.9.18 interpreter at: /Users/zb/Library/Application Support/uv/toolchains/cpython-3.9.18-macos-aarch64-none/install/bin/python3 Creating virtualenv at: .venv INFO Removing existing directory Activate with: source .venv/bin/activate ``` The preview flag is required. The fetch is performed if we can't find an interpreter that satisfies the request. Once fetched, the toolchain will be available for later invocations that include the `--preview` flag. There will be follow-ups to improve toolchain management in general, there is still outstanding work from the initial implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #4120
Part of #2607
There should be no behavior changes here. Restructures the discovery API to be focused on a toolchain first perspective in preparation for exposing a
find_or_fetchmethod for toolchains in #4138.