Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect workspace-wide requires-python in interpreter selection #4298

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jun 13, 2024

Summary

Closes #4296.

Test Plan

Ran cargo run lock --verbose from scripts/workspaces/albatross-virtual-workspace:

DEBUG uv 0.2.11 (ef3bc1612 2024-06-12)
warning: `uv lock` is experimental and may change without warning.
DEBUG Found workspace root: `/Users/crmarsh/workspace/puffin/scripts/workspaces/albatross-virtual-workspace`
DEBUG Adding discovered workspace member: /Users/crmarsh/workspace/puffin/scripts/workspaces/albatross-virtual-workspace/packages/albatross
DEBUG Adding discovered workspace member: /Users/crmarsh/workspace/puffin/scripts/workspaces/albatross-virtual-workspace/packages/bird-feeder
DEBUG Adding discovered workspace member: /Users/crmarsh/workspace/puffin/scripts/workspaces/albatross-virtual-workspace/packages/seeds
DEBUG Searching for Python >=3.12 in search path or managed toolchains
DEBUG Searching for managed toolchains at `/Users/crmarsh/Library/Application Support/uv/toolchains`
DEBUG Found managed toolchain `cpython-3.12.3-macos-aarch64-none`
DEBUG Found CPython 3.12.3 at `/Users/crmarsh/Library/Application Support/uv/toolchains/cpython-3.12.3-macos-aarch64-none/install/bin/python3` (managed toolchains)
Using Python 3.12.3 interpreter at: /Users/crmarsh/Library/Application Support/uv/toolchains/cpython-3.12.3-macos-aarch64-none/install/bin/python3

@charliermarsh charliermarsh added bug Something isn't working preview Experimental behavior labels Jun 13, 2024
@charliermarsh
Copy link
Member Author

Something that needs coverage as part of #3943.

@charliermarsh charliermarsh enabled auto-merge (squash) June 13, 2024 12:49
@charliermarsh charliermarsh merged commit 5d1305a into main Jun 13, 2024
47 checks passed
@charliermarsh charliermarsh deleted the charlie/virtual branch June 13, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv lock does not respect Requires-Python in a virtual workspace
2 participants