Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit project name from workspace errors #4299

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

Because the workspace member itself is part of the resolution, adding the workspace name for the project leads to confusing errors, like:

❯ cargo run lock --preview
   Compiling uv v0.2.11 (/Users/crmarsh/workspace/puffin/crates/uv)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.79s
     Running `/Users/crmarsh/workspace/puffin/target/debug/uv lock --preview`
  × No solution found when resolving dependencies:
  ╰─▶ Because only albatross==0.1.0 is available and albatross==0.1.0 depends on anyio<=3, we can conclude that all versions of albatross depend on anyio<=3.
      And because bird-feeder==1.0.0 depends on anyio>=4.3.0,<5 and only bird-feeder==1.0.0 is available, we can conclude that all versions of albatross and all versions of bird-feeder are incompatible.
      And because albatross depends on albatross and bird-feeder, we can conclude that the requirements are unsatisfiable.

(Notice "albatross depends on albatross".)

@charliermarsh charliermarsh added error messages Messaging when something goes wrong preview Experimental behavior labels Jun 13, 2024
Base automatically changed from charlie/virtual to main June 13, 2024 12:55
"The `requires-python` field does not contain a lower bound: `{requires_python}`. Set a lower bound to indicate the minimum compatible Python version (e.g., `{default}`).",
);
}
warn_user!("The `requires-python` field does not contain a lower bound: `{requires_python}`. Set a lower bound to indicate the minimum compatible Python version (e.g., `{default}`).");
Copy link
Member

@zanieb zanieb Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say... "The workspace requires-pythonfield..."?

@charliermarsh charliermarsh merged commit db84825 into main Jun 14, 2024
47 checks passed
@charliermarsh charliermarsh deleted the charlie/project-name branch June 14, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error messages Messaging when something goes wrong preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants