Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --no-binary with uv pip compile #4301

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

brianmego
Copy link
Contributor

Summary

This i still a draft, but it gets some of the work started on issue #4064 , which requests --no-binary functionality similar to uv pip install to exist on uv pip compile.

So far this has moved the command line shape from install and cloned it over to compile. The actual functionality of respecting --no-binary and generating the resulting line in requirements.txt I could use a hand with.

My understanding is we want to create a requirements.in file such as:

yt

Then when running cargo run -- pip compile --no-binary yt requirements.in
we want the file to have this line in it:

yt==4.3.1 --no-binary yt

Test Plan

Existing unit tests continue to pass.
No new unit tests have been created yet.
The new command line options do show up when testing with cargo run -- pip compile -h

@charliermarsh
Copy link
Member

I think this is actually "done". I'll add a test to demonstrate it.

@charliermarsh charliermarsh changed the title Draft: Copies some of the install no-binary code over to compile (#4064) Allow --no-binary with uv pip compile Jun 13, 2024
@charliermarsh charliermarsh added the cli Related to the command line interface label Jun 13, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) June 13, 2024 13:51
@charliermarsh charliermarsh merged commit cd461f1 into astral-sh:main Jun 13, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants