Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display keyring stderr #4343

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

samypr100
Copy link
Contributor

@samypr100 samypr100 commented Jun 16, 2024

Summary

Closes #4162

Changes keyring subprocess to allow display of stderr.
This aligns with pip's behavior since pip 23.1.

Test Plan

  • Tested using gnome-keyring-backend on a self-hosted private registry as well as the keyring script described in Keyring stderr is not displayed #4162 to confirm both existing functionality and the new stderr display.
  • Existing tests using scripts/packages/keyring_test_plugin are now showing its stderr output as well.

@zanieb zanieb self-assigned this Jun 16, 2024
@samypr100 samypr100 marked this pull request as ready for review June 16, 2024 19:30
@konstin konstin requested a review from zanieb June 17, 2024 08:58
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb merged commit a0eca1a into astral-sh:main Jun 17, 2024
47 checks passed
@zanieb zanieb added the enhancement New feature or request label Jun 17, 2024
@samypr100 samypr100 deleted the keyring-stderr branch June 17, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyring stderr is not displayed
2 participants