Add context to unregistered task name to error context #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
approved these changes
Jun 24, 2024
|
Is the dist ID enough to distinguish the "task"? |
|
I have also done something like this so very much in favor. |
| .wait_blocking(&version_id) | ||
| .ok_or(ResolveError::Unregistered)?; | ||
| .wait_blocking(&dist.version_id()) | ||
| .ok_or(ResolveError::Unregistered(dist.version_id().to_string()))?; |
There was a problem hiding this comment.
Should these now be in a closure to avoid allocation?
For me the problem was package name vs. url so this was sufficient |
konstin
force-pushed
the
konsti/unregistered-context
branch
from
32d72f8
to
6c4a50c
Compare
I caused this error during development and having the name of the task on it is helpful for debugging.
konstin
force-pushed
the
konsti/unregistered-context
branch
from
6c4a50c
to
bb48d69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I caused this error during development and having the name of the task on it is helpful for debugging.
Split out from #4435