Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project::update_environment to respect reinstall options #4502

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jun 25, 2024

While working on #4492 I noticed that --reinstall-package was not actually respected by update_environment, it exited early due to satisfied requirements.

Before


❯ cargo run -q -- tool install black -v --reinstall-package tomli
...
DEBUG All requirements satisfied: black | click>=8.0.0 | mypy-extensions>=0.4.3 | packaging>=22.0 | pathspec>=0.9.0 | platformdirs>=2 | tomli>=1.1.0 ; python_version < '3.11' | typing-extensions>=4.0.1 ; python_version < '3.11'

After

❯ cargo run -q -- tool install black -v --reinstall-package tomli
...
Uninstalled 1 package in 0.99ms
Installed 1 package in 4ms
 - tomli==2.0.1
 + tomli==2.0.1

@zanieb zanieb added bug Something isn't working preview Experimental behavior labels Jun 25, 2024
@zanieb zanieb force-pushed the zb/reinstall-satisfies branch from 9e07261 to 0049aa8 Compare June 25, 2024 01:27
@zanieb zanieb requested a review from charliermarsh June 25, 2024 18:59
@zanieb zanieb marked this pull request as ready for review June 25, 2024 18:59
@charliermarsh charliermarsh merged commit e242cdf into main Jun 25, 2024
47 checks passed
@charliermarsh charliermarsh deleted the zb/reinstall-satisfies branch June 25, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants