Make .egg-info filename parsing spec compliant
#4533
Merged
+228
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
bug
|
\cc @samypr100 |
charliermarsh
force-pushed
the
charlie/egg
branch
3 times, most recently
from
2dd3ae7
to
7dacaaa
Compare
samypr100
reviewed
Jun 25, 2024
charliermarsh
force-pushed
the
charlie/egg
branch
from
7dacaaa
to
245dcad
Compare
severen
added a commit
to severen/uv
that referenced
this pull request
Aug 18, 2024
PR astral-sh#4533 introduced (almost) spec compliant parsing of .egg-info filenames, but added the overly strict requirement that the distribution version must be present. This causes various `uv pip` operations to fail in environments where there are .egg-info files without a version component, so loosen this check by making the version component optional.
severen
added a commit
to severen/uv
that referenced
this pull request
Aug 18, 2024
PR astral-sh#4533 introduced (almost) spec compliant parsing of .egg-info filenames, but added the overly strict requirement that the distribution version must be present. This causes various `uv pip` operations to fail in environments where there are .egg-info files without a version component, so loosen this check by making the version component optional.
severen
added a commit
to severen/uv
that referenced
this pull request
Aug 18, 2024
PR astral-sh#4533 introduced (almost) spec compliant parsing of .egg-info filenames, but added the overly strict requirement that the distribution version must be present. This causes various `uv pip` operations to fail in environments where there are .egg-info files without a version component, so loosen this check by making the version component optional and reading the version from the egg metadata when it is not present.
charliermarsh
pushed a commit
that referenced
this pull request
Aug 18, 2024
## Summary PR #4533 introduced (almost) spec compliant parsing of `.egg-info` filenames, but added the overly strict requirement that the distribution version must be present. This causes various `uv pip` operations to fail in environments where there are `.egg-info` files without a version component, so loosen this check by making the version component optional and reading the version from the egg metadata when it is not present. As an example of the issue, running `uv pip list` on my system currently results in ``` error: Failed to read metadata from: `/usr/lib/python3.12/site-packages/PySide6.egg-info` Caused by: The `.egg-info` filename "PySide6.egg-info" is missing a version ``` whereas regular `pip list` succeeds: ``` $ pip list | rg -S pyside PySide6 6.7.2 ``` ## Test Plan This has been tested by altering the `.egg-info` filename tests as needed and ensuring the full test suite passes locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It turns out that
.egg-infofiles and directories can both have up to four segments in the filename: https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html#filename-embedded-metadata. This PR upgrades the parsing and now uses the same parsing for files and directories.Closes #4532.