Make uv.sources without --preview non-fatal
#4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Jun 26, 2024
| @@ -43,7 +43,7 @@ pub(crate) async fn add( | |||
| printer: Printer, | |||
| ) -> Result<ExitStatus> { | |||
| if preview.is_disabled() { | |||
| warn_user!("`uv add` is experimental and may change without warning."); | |||
| warn_user_once!("`uv add` is experimental and may change without warning."); | |||
There was a problem hiding this comment.
Just changed all of these for consistency.
charliermarsh
force-pushed
the
charlie/preview
branch
3 times, most recently
from
92b5df2
to
7933ac7
Compare
charliermarsh
force-pushed
the
charlie/preview
branch
from
7933ac7
to
f1d4c42
Compare
zanieb
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Like other preview usages, this should just warn.