Drop prefer prefix from toolchain-preference values
#4602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
changed the title
prefer prefix from toolchain-prefixprefer prefix from toolchain-preference
zanieb
force-pushed
the
zb/toolchain-preference-only
branch
from
6e42bcd
to
64ded97
Compare
charliermarsh
approved these changes
Jun 27, 2024
zanieb
changed the title
prefer prefix from toolchain-preferenceprefer prefix from toolchain-preference values
zanieb
force-pushed
the
zb/toolchain-fetch-strategy
branch
5 times, most recently
from
6ceeeca
to
5fed93b
Compare
zanieb
force-pushed
the
zb/toolchain-preference-only
branch
from
64ded97
to
77c3bd9
Compare
zanieb
force-pushed
the
zb/toolchain-preference-only
branch
from
77c3bd9
to
d5a9cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
--toolchain-preference systemis sufficiently clear and--toolchain-preference prefer-systemis excessively verbose. This was discussed in the original pull request at #4424 but because we had a case for preferring "installed managed" toolchains I was hesitant to change it. Now that I've dropped that in #4601, I think we can drop the prefix.