Allow uv add to specify optional dependency groups
#4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
force-pushed
the
uv-add-optional
branch
from
e61e0a4
to
d122994
Compare
| @@ -143,3 +136,22 @@ pub(crate) async fn remove( | |||
|
|
|||
| Ok(ExitStatus::Success) | |||
| } | |||
|
|
|||
| /// Emit a warning if a dependency with the given name is present as any dependency type. | |||
| fn warn_dependency_types(name: &PackageName, pyproject: &PyProjectTomlMut) { | |||
There was a problem hiding this comment.
Should this just be part of the anyhow::bail!? It took me a sec to realize that this running after we've been unable to find the dependency in some other group. I wonder if there's a way to structure the code such that the data flow is clearer. Maybe just a matter of expanding the documentation.
There was a problem hiding this comment.
Renamed to warn_if_present and updated the docs.
charliermarsh
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements
uv add --optional <group>, which adds a dependency toproject.optional-dependency.<group>.Resolves #4585.