Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement --invert for pip tree #4621

Merged
merged 12 commits into from
Jul 1, 2024

Conversation

ChannyClaus
Copy link
Contributor

@ChannyClaus ChannyClaus commented Jun 28, 2024

Summary

partially resolves #4439

Test Plan

existing tests pass + added a couple of new tests with --invert.

crates/uv/src/commands/pip/tree.rs Outdated Show resolved Hide resolved
crates/uv/tests/pip_tree.rs Show resolved Hide resolved
Copy link
Member

@ibraheemdev ibraheemdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to see how --invert interacts with --no-dedupe? After that this looks good to me.

@ChannyClaus
Copy link
Contributor Author

all done 🌵

@Peiffap
Copy link
Contributor

Peiffap commented Jun 29, 2024

I haven't looked at the implementation in detail, but is there a reason we want this to be --invert instead of --reverse like in pipdeptree?

@ChannyClaus
Copy link
Contributor Author

ChannyClaus commented Jun 30, 2024

I haven't looked at the implementation in detail, but is there a reason we want this to be --invert instead of --reverse like in pipdeptree?

no reason, i just followed the naming convention in cargo tree, but if there's an overall preference for --reverse i'm happy to rename 👍

@zanieb
Copy link
Member

zanieb commented Jun 30, 2024

I kind of find --invert clearer, but we can provide a hidden alias --reverse for pipdeptree compatibility.

@ibraheemdev ibraheemdev mentioned this pull request Jul 1, 2024
6 tasks
@ibraheemdev ibraheemdev added the cli Related to the command line interface label Jul 1, 2024
@ibraheemdev ibraheemdev merged commit 5715def into astral-sh:main Jul 1, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv pip tree improvement
4 participants