Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit pythonX.Y segment in stdlib on managed Windows #4727

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Omit pythonX.Y segment in stdlib on managed Windows #4727

merged 1 commit into from
Jul 2, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jul 2, 2024 •
edited
Loading

Summary

Windows omits this segment, IIRC.

Closes #4724.

@charliermarsh charliermarsh requested a review from zanieb July 2, 2024 12:36
@charliermarsh charliermarsh added bug Something isn't working windows Specific to the Windows platform labels Jul 2, 2024
konstin
konstin approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that this fixes the bug on windows

@charliermarsh charliermarsh merged commit d05bb45 into main Jul 2, 2024
47 checks passed
@charliermarsh charliermarsh deleted the charlie/w branch July 2, 2024 13:21
@charliermarsh
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

@zanieb zanieb Awaiting requested review from zanieb

Assignees
No one assigned
Labels
bug Something isn't working windows Specific to the Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uv toolchain install 3.11.9 failed in uv 0.2.18 on Windows 11 23H2.
2 participants
@charliermarsh @konstin