-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use aws-lc-rs instead of ring for TLS #4734
Changes from all commits
075423e
f25c467
58e7c42
705ad51
7fdb31c
616673b
12850cc
cf73ab5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,6 +82,8 @@ jobs: | |
name: "cargo clippy | windows" | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: "Install nasm" | ||
uses: ilammy/setup-nasm@v1 | ||
- name: "Install Rust toolchain" | ||
run: rustup target add x86_64-pc-windows-msvc | ||
- name: Load xwin cache | ||
|
@@ -201,7 +203,7 @@ jobs: | |
steps: | ||
- name: Create Dev Drive using ReFS | ||
run: | | ||
$Volume = New-VHD -Path C:/uv_dev_drive.vhdx -SizeBytes 12GB | | ||
$Volume = New-VHD -Path C:/uv_dev_drive.vhdx -SizeBytes 14GB | | ||
Mount-VHD -Passthru | | ||
Initialize-Disk -Passthru | | ||
New-Partition -AssignDriveLetter -UseMaximumSize | | ||
|
@@ -216,6 +218,9 @@ jobs: | |
run: | | ||
Copy-Item -Path "${{ github.workspace }}" -Destination "${{ env.DEV_DRIVE }}/uv" -Recurse | ||
|
||
- name: "Install nasm" | ||
uses: ilammy/setup-nasm@v1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note to self we should audit this action and consider just implementing it ourself if the install is straightforward There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ilammy also known for https://github.com/ilammy/msvc-dev-cmd |
||
|
||
- name: "Install Rust toolchain" | ||
working-directory: ${{ env.DEV_DRIVE }}/uv | ||
env: | ||
|
@@ -412,7 +417,7 @@ jobs: | |
steps: | ||
- name: Create Dev Drive using ReFS | ||
run: | | ||
$Volume = New-VHD -Path C:/uv_dev_drive.vhdx -SizeBytes 10GB | | ||
$Volume = New-VHD -Path C:/uv_dev_drive.vhdx -SizeBytes 12GB | | ||
kcon-stackav marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Mount-VHD -Passthru | | ||
Initialize-Disk -Passthru | | ||
New-Partition -AssignDriveLetter -UseMaximumSize | | ||
|
@@ -429,6 +434,9 @@ jobs: | |
|
||
- uses: rui314/setup-mold@v1 | ||
|
||
- name: "Install nasm" | ||
uses: ilammy/setup-nasm@v1 | ||
|
||
- uses: Swatinem/rust-cache@v2 | ||
with: | ||
workspaces: ${{ env.DEV_DRIVE }}/uv | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zanieb I'm not very familiar with maturin, do you think installing NASM is needed for the
build-binaries
Windows job too?uv/.github/workflows/build-binaries.yml
Lines 153 to 162 in 66a4b8e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @konstin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maturin calls
cargo build
, so they same rules should apply whether it's maturin or not.