Use already-installed tools in uv tool run
#4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
changed the title
uv tool run
zanieb
reviewed
Jul 2, 2024
zanieb
reviewed
Jul 2, 2024
charliermarsh
force-pushed
the
charlie/reuse-tool-env
branch
from
168d978
to
28969c3
Compare
|
Dangerous to review your pull requests so soon. We should include tests with:
|
charliermarsh
force-pushed
the
charlie/reuse-tool-env
branch
from
28969c3
to
92b734b
Compare
|
Good call, added! |
charliermarsh
force-pushed
the
charlie/reuse-tool-env
branch
from
92b734b
to
c7619b1
Compare
charliermarsh
force-pushed
the
charlie/reuse-tool-env
branch
2 times, most recently
from
cf784d8
to
9313265
Compare
zanieb
approved these changes
Jul 3, 2024
zanieb
reviewed
Jul 3, 2024
Comment on lines
+310
to
+311
| // TODO(charlie): This could (in theory) layer the `--with` requirements on top of the existing | ||
| // environment. |
charliermarsh
force-pushed
the
charlie/reuse-tool-env
branch
from
9313265
to
ddde9d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This doesn't cache the tool environment; rather, it just uses the
tool installenvironment if it satisfies the request.Closes #4742.