Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incompatible wheels from uv.lock #4799

Merged
merged 1 commit into from
Jul 4, 2024

Commits on Jul 4, 2024

  1. Remove incompatible wheels from uv.lock

    Remove wheels that don't match the required python version from the lockfile. For example, we remove `charset_normalizer-3.3.2-cp311-cp311-win_amd64.whl` when we have `requires-python = ">=3.12"`.
    
    Our snapshots barely show changes since we avoid the large binaries for which matters. Here are 3 real world `uv.lock` before/after comparisons to show the large difference:
    * [warehouse](https://gist.github.com/konstin/9a1ed6a32b410e250fcf4c6ea8c536a5) 5677 -> 4214
    * [transformers](https://gist.github.com/konstin/5636281b5226f64aa44ce3244d5230cd) 6484 -> 5816
    * [github-wikidata-bot](https://gist.github.com/konstin/ebbd7b9474523aaa61d9a8945bc02071) 793 -> 454
    
    We only remove wheels we are certain don't match the python version and still keep those with unknown tags. We could remove even more wheels by also considering other markers, e.g. removing linux wheels for a windows-only dep, but we would trade complex, easy-to-get-wrong logic for diminishing returns.
    konstin committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    37c9b4e View commit details
    Browse the repository at this point in the history