Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide --isolated global argument #5005

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Jul 12, 2024

Summary

This PR makes the --isolated global argument visible, previously it was hidden.
Fixes #4981.

Test Plan

I ran cargo run -- help to verify --isolated was visible and it is.
I ran clippy with cargo clippy --workspace --all-targets --all-features --locked -- -D warnings as CI does.

I also ran tests locally with:

cargo nextest run \
            --features python-patch \
            --workspace \
            --status-level skip --failure-output immediate-final --no-fail-fast -j 12 --final-status-level slow

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb added the cli Related to the command line interface label Jul 12, 2024
@zanieb zanieb merged commit 663c190 into astral-sh:main Jul 12, 2024
49 checks passed
@silvanocerza silvanocerza deleted the unhide-isolated branch July 13, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--isolated should not be a hidden option
2 participants