Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry on permission errors when persisting extracted source distributions to the cache #5076

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Retry on permission errors when persisting extracted source distributions to the cache #5076

merged 1 commit into from
Jul 15, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jul 15, 2024 •
edited
Loading

Another case for #1491

ref #4606

@zanieb zanieb added the bug Something isn't working label Jul 15, 2024
@zanieb
Copy link
Member Author

zanieb commented Jul 15, 2024 •
edited
Loading

I believe this is actually the last remaining case of fs_err::tokio::rename. As previously noted, there are also synchronous rename calls that we do not retry on yet.

@zanieb zanieb merged commit dab7fc7 into main Jul 15, 2024
49 checks passed
@zanieb zanieb deleted the zb/retry-cache-windows branch July 15, 2024 17:56
@BrewTestBot BrewTestBot mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @BurntSushi