Skip invalid tools in uv tool list
#5156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
changed the title
uv tool list
charliermarsh
force-pushed
the
charlie/l
branch
4 times, most recently
from
3ac204e
to
10f554c
Compare
zanieb
reviewed
Jul 18, 2024
crates/uv/src/commands/tool/list.rs
Outdated
| // Skip invalid tools | ||
| let Ok(tool) = tool else { | ||
| warn_user!( | ||
| "Ignoring malformed tool `{name}` (use {} to remove)", |
There was a problem hiding this comment.
Suggested change
| "Ignoring malformed tool `{name}` (use {} to remove)", | |
| "Ignoring malformed tool `{name}` (use `{}` to remove)", |
There was a problem hiding this comment.
It's green though so I intentionally omitted this, what do you think?
There was a problem hiding this comment.
Oh. I don't think the color is enough alone (and it's not great for users with colorblindness or colors turned off).
zanieb
reviewed
Jul 18, 2024
crates/uv/tests/tool_list.rs
Outdated
| @@ -84,8 +84,7 @@ fn tool_list_missing_receipt() { | |||
|
|
|||
| ----- stderr ----- | |||
| warning: `uv tool list` is experimental and may change without warning. | |||
| warning: Ignoring malformed tool `black`: missing receipt | |||
| No tools installed | |||
| warning: Ignoring malformed tool `black` (use uv tool uninstall black to remove) | |||
There was a problem hiding this comment.
Suggested change
| warning: Ignoring malformed tool `black` (use uv tool uninstall black to remove) | |
| warning: Ignoring malformed tool `black` (use `uv tool uninstall black` to remove) |
zanieb
reviewed
Jul 18, 2024
zanieb
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
tools()return value include per-tool errors. This makes it easy to skip (rather than failing) inuv tool list, and improvesuv tool uninstallto remove those invalid tools, rather than leaving them around. (We already had that behavior foruv tool uninstall ruffwith an invalidruff, butuv tool uninstall --alljust left them.)Closes #5151.