Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way to inspect installation scripts on Powershell(Windows) #5157

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Added a way to inspect installation scripts on Powershell(Windows) #5157

merged 2 commits into from
Jul 19, 2024

Conversation

FishAlchemist
Copy link
Contributor

@FishAlchemist FishAlchemist commented Jul 17, 2024

Summary

command

   powershell -c "irm https://astral.sh/uv/install.ps1 | more"

Add a method to inspect installation script files that works on Windows, it may not work on other platforms supported by PowerShell.

Other platforms information:
PowerShell differences on non-Windows platforms / General Unix interoperability changes
Differences between Windows PowerShell 5.1 and PowerShell 7.x / Removal of the more function

Test Plan

terminal

  • Powershell Version: 5.1.22621.3880 (Windows)
    image
  • Powershell Version: 7.4.3 (Windows)
    image

Result (Website)

image

@zanieb zanieb self-assigned this Jul 18, 2024
@zanieb zanieb enabled auto-merge (squash) July 19, 2024 14:28
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated this to match the code block style above.

@zanieb zanieb merged commit b1a350c into astral-sh:main Jul 19, 2024
44 checks passed
@zanieb zanieb added documentation Improvements or additions to documentation preview Experimental behavior labels Jul 19, 2024
@FishAlchemist
Copy link
Contributor Author

Thanks! Updated this to match the code block style above.

I intentionally split them into two code blocks so that only the expected commands would be copied to the clipboard.

@zanieb
Copy link
Member

zanieb commented Jul 19, 2024

Fair, but we need to be consistent — we can't change styles mid-section like that. We should consider changing both instead.

@FishAlchemist FishAlchemist deleted the FishAlchemist/add_inspect_windows branch July 19, 2024 14:58
@FishAlchemist FishAlchemist restored the FishAlchemist/add_inspect_windows branch July 19, 2024 14:59
@FishAlchemist FishAlchemist deleted the FishAlchemist/add_inspect_windows branch July 19, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants