Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use which-retrieved path directly when spawning pager #5198

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Use which-retrieved path directly when spawning pager #5198

merged 1 commit into from
Jul 18, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #5124.

Test Plan

Ran cargo run -- help pip compile on my Windows machine, which failed before but succeeds after this change.

@charliermarsh charliermarsh added bug Something isn't working windows Specific to the Windows platform labels Jul 18, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) July 18, 2024 20:21
@charliermarsh charliermarsh merged commit 54bca18 into main Jul 18, 2024
52 checks passed
@charliermarsh charliermarsh deleted the charlie/page branch July 18, 2024 20:29
@zanieb
Copy link
Member

zanieb commented Jul 18, 2024

Glad that worked!

@BrewTestBot BrewTestBot mentioned this pull request Jul 20, 2024
Merged
@charliermarsh charliermarsh mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working windows Specific to the Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: uv help pip compile failing with error: program not found
2 participants
@charliermarsh @zanieb