Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a style guide #5209

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Add a style guide #5209

merged 8 commits into from
Jul 23, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jul 19, 2024

No description provided.

@zanieb zanieb added documentation Improvements or additions to documentation internal A refactor or improvement that is not user-facing labels Jul 19, 2024
@zanieb zanieb force-pushed the zb/style branch 3 times, most recently from afdc109 to 0a2986a Compare July 19, 2024 02:10
STYLE.md Outdated Show resolved Hide resolved
## General

1. Use of "e.g." and "i.e." should always be wrapped in commas, e.g., as shown here.
1. Em-dashes are okay, but not recommended when using monospace fonts. Use "—", not "--" or "-".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we stay with ascii in input files where possible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's an input file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our plain text files, e.g. markdown files, as opposed to rich output files such as html. For example, latex has \textemdash and converts that to a real em dash in the pdf output.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In documentation? I have a pretty strong preference for being able to use em dashes in the markdown.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-unicode characters are a nuisance to enter, esp. across keyboard layouts, and when they look like an ascii characters they tend to cause unnecessary debugging

STYLE.md Outdated Show resolved Hide resolved
STYLE.md Outdated Show resolved Hide resolved
STYLE.md Outdated Show resolved Hide resolved
1. Do not use the `bash` syntax when displaying command output.
1. Command output should rarely be included — it's hard to keep up to date.

## CLI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have an error message, are the hints before or after the error message? Do we include urls in messages? When do we (not) capitalize?

STYLE.md Show resolved Hide resolved
STYLE.md Outdated Show resolved Hide resolved
STYLE.md Show resolved Hide resolved
STYLE.md Outdated Show resolved Hide resolved
STYLE.md Outdated Show resolved Hide resolved
charliermarsh added a commit that referenced this pull request Jul 19, 2024
## Summary

Per #5209, we only show periods in messages when the message itself
spans more than a single sentence.
STYLE.md Outdated Show resolved Hide resolved
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine to merge this whenever and iterate.

@zanieb
Copy link
Member Author

zanieb commented Jul 23, 2024

Let's send it — lots more to do here though.

@zanieb zanieb marked this pull request as ready for review July 23, 2024 17:57
@zanieb zanieb merged commit 337a1c2 into main Jul 23, 2024
44 checks passed
@zanieb zanieb deleted the zb/style branch July 23, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants