Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv init ignores workspace when --isolated flag is used #5290

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

j178
Copy link
Contributor

@j178 j178 commented Jul 22, 2024

Summary

Per #5250 (comment)

It would also be great to have an argument (perhaps leveraging the global isolated option) that allows us to disable workspace discovery when we don't want to add a project as a member.

Test Plan

$cargo run -- init work
$ cargo run -- init work/pkg-a --isolated
warning: `uv init` is experimental and may change without warning
Initialized project sub-c in /tmp/work

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add a test case?

@zanieb zanieb added cli Related to the command line interface preview Experimental behavior labels Jul 22, 2024
@j178
Copy link
Contributor Author

j178 commented Jul 22, 2024

Sure!

@zanieb
Copy link
Member

zanieb commented Jul 22, 2024

I'm going to have @charliermarsh take a look here — we're thinking about the future of the --isolated flag.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now, since it's consistent with uv run and we need to revisit this alongside that usage.

@charliermarsh charliermarsh merged commit f00c3f2 into astral-sh:main Jul 22, 2024
54 checks passed
@j178 j178 deleted the isolated branch July 22, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants