Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid including empty extras in resolution #5306

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jul 22, 2024

Summary

You can still generate instabilities, but at least it's consistent between including and excluding the extra.

For example, this resolves to 54 and then 52 packages on re-run:

[project]
name = "transformers"
version = "4.39.0.dev0"
description = "State-of-the-art Machine Learning for JAX, PyTorch and TensorFlow"
requires-python = ">=3.9.0"

dependencies = []

[project.optional-dependencies]
flax = ["jaxlib>=0.4.1,<=0.4.13"]
onnxruntime = ["onnxruntime>=1.4.0"]
ray = ["ray[tune]>=2.7.0"]
deepspeed-testing = [
  "dill<0.3.5",
  "datasets!=2.5.0",
]

[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"

I think the difference is just somewhere in PubGrub -- like, we add an extra dependency, so the iteration order gets changed, and we end up with a different resolution at the end.

Closes #5285.

@charliermarsh charliermarsh added the bug Something isn't working label Jul 22, 2024
@charliermarsh charliermarsh merged commit 84b351a into main Jul 22, 2024
54 checks passed
@charliermarsh charliermarsh deleted the charlie/extr branch July 22, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolution depends on empty extra
1 participant