Stable sorting of requirements.txt in universal mode #5334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RequirementsTxtComparator` was written assuming there is one distribution per name. This changed with the universal resolution, which allows multiple versions or urls for the same package name. The sorting we emitted was incidental, with this change we properly sort these entries by name, version and then url.
konstin
added
the
enhancement
charliermarsh
approved these changes
Jul 23, 2024
|
Not sure what's going on with those two CI jobs, but they are not related to changes in this PR |
konstin
deleted the
konsti/stable-sorting-of-requirements-txt-in-univerval-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RequirementsTxtComparatorwas written assuming there is one distribution per package name. This changed with the universal resolution, which allows multiple versions or urls for the same package name. The sorting we emitted for these new entries was incidental.With this change, we properly sort these entries by name, version and then url in universal mode.
This is an output format change for
--universalusers.