Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase padding between each nav section #5373

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Increase padding between each nav section #5373

merged 1 commit into from
Jul 23, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jul 23, 2024 •
edited
Loading

Screenshot 2024-07-23 at 3 46 45 PM Screenshot 2024-07-23 at 3 46 53 PM Screenshot 2024-07-23 at 3 46 57 PM Screenshot 2024-07-23 at 3 47 10 PM

@zanieb zanieb added documentation Improvements or additions to documentation preview Experimental behavior labels Jul 23, 2024
charliermarsh
charliermarsh approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The net effect is more space between the items on the far left?

@zanieb
Copy link
Member Author

zanieb commented Jul 23, 2024

Yes, sorry for not including a note. This increase the padding above the each top-level nav section e.g. "Guides" and "Concepts" to improve the clarity of the section groupings. The section items have a slightly reduced padding to compensate for the increase. There is no change for the "expandable" nav on small screens.

@zanieb zanieb merged commit 499b035 into main Jul 23, 2024
45 checks passed
@zanieb zanieb deleted the zb/nav-section-spacing branch July 23, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation preview Experimental behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @charliermarsh