Validate successful metadata fetch for direct dependencies #5392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/extract
branch
3 times, most recently
from
50ba902
to
7ba49f2
Compare
charliermarsh
force-pushed
the
charlie/off
branch
from
9bcbd77
to
b2d6a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this change, the resolver would panic if we ran with
--offlineand--no-depsand we had cached metadata for a package (i.e., the versions) but no cached metadata for the distribution (i.e., the specific wheel), since we weren't validating that the returned metadata in the--no-depscase was actually successful. (We need metadata, even for--no-deps, so that we can validate extras.)Test Plan
The added test panics on the previous branch.