Error when multiple git references are provided in uv add
#5502
+71
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
force-pushed
the
add-group-gitref
branch
2 times, most recently
from
2572de7
to
def261d
Compare
This allows us to reject specifying more than one git-ref at the CLI level.
eth3lbert
force-pushed
the
add-group-gitref
branch
from
def261d
to
e99d938
Compare
|
I wonder if there's a use-case where we'd want to allow multiple to be passed and just confirm they resolve to consistent values? Seems weird though. |
zanieb
approved these changes
Jul 30, 2024
zanieb
added
cli
zanieb
changed the title
git-ref group for uv adduv add
I think that would cause more trouble than it's worth, and might consider using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows us to reject specifying more than one git-ref at the cli level.
Test Plan
Test cases included.