Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize forks based on Python narrowing #5642

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

First part of: #4926. We should solve forks that don't expand the world of supported versions (e.g., python_version >= '3.11' enables us to select new packages, since we narrow the supported version range).

@charliermarsh charliermarsh added enhancement New feature or improvement to existing functionality preview Experimental behavior labels Jul 30, 2024
@charliermarsh charliermarsh marked this pull request as ready for review July 30, 2024 23:25
Copy link

codspeed-hq bot commented Jul 30, 2024

CodSpeed Performance Report

Merging #5642 will improve performances by 10.8%

Comparing charlie/prioritiz (e268bed) with main (cbb13e6)

Summary

⚡ 1 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main charlie/prioritiz Change
resolve_warm_jupyter 100.1 ms 90.3 ms +10.8%

Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Resolved 41 packages in [TIME]
+ Resolved 34 packages in [TIME]

nice

@charliermarsh charliermarsh merged commit f268b7c into main Jul 31, 2024
57 checks passed
@charliermarsh charliermarsh deleted the charlie/prioritiz branch July 31, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to existing functionality preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants