-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prioritize forks based on upper bounds #5643
Conversation
1afe35a
to
b639021
Compare
}) | ||
.count(); | ||
|
||
self_upper_bounds.cmp(&other_upper_bounds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heuristic of course, and we don't really have a ton of examples to inform this work.
While this is an improvement, it does not fix the transformers example. Fork points for transformers:
|
@konstin - Can you link to that example, and I'll explore it? |
b639021
to
ef01ac5
Compare
I'Ve added it in #5657 |
Thanks! I'll merge this and then explore that separately. |
Summary
Given a fork like:
Solving the top branch will typically yield a solution that also satisfies the bottom branch, due to maximum version selection (while the inverse isn't true).
To quote an example from the docs:
Closes #4926 for now.