Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the documentation #5718

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Improvements to the documentation #5718

merged 1 commit into from
Aug 3, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Aug 2, 2024

No description provided.

@zanieb zanieb added documentation Improvements or additions to documentation preview Experimental behavior labels Aug 2, 2024
Comment on lines 15 to 16
$ # Create a virtual environment at `.venv`
uv venv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ # Create a virtual environment at `.venv`
uv venv
$ # Create a virtual environment at `.venv`
$ uv venv

docs/pip/environments.md Outdated Show resolved Hide resolved
docs/pip/environments.md Outdated Show resolved Hide resolved
docs/pip/environments.md Outdated Show resolved Hide resolved
docs/pip/packages.md Outdated Show resolved Hide resolved
@zanieb
Copy link
Member Author

zanieb commented Aug 2, 2024

@eth3lbert thank you! I fixed those, though I mostly tried to move content outside of the codeblock.

@eth3lbert
Copy link
Contributor

eth3lbert commented Aug 2, 2024

@zanieb You should probably also add a $ at the beginning of # comments.

While serving this locally, I noticed it transforms the code block into the following on the website (http://localhost:8000/uv/guides/integration/alternative-indexes/#using-keyring):

<code tabindex="0"><a id="__codelineno-1-1" name="__codelineno-1-1" href="http://localhost:8000/uv/guides/integration/alternative-indexes/#__codelineno-1-1"></a><span class="gp"># </span>Pre-install<span class="w"> </span>keyring<span class="w"> </span>and<span class="w"> </span>the<span class="w"> </span>Artifacts<span class="w"> </span>plugin<span class="w"> </span>from<span class="w"> </span>the<span class="w"> </span>public<span class="w"> </span>PyPI
<a id="__codelineno-1-2" name="__codelineno-1-2" href="http://localhost:8000/uv/guides/integration/alternative-indexes/#__codelineno-1-2"></a><span class="gp">$ </span>uv<span class="w"> </span>tool<span class="w"> </span>install<span class="w"> </span>keyring<span class="w"> </span>--with<span class="w"> </span>artifacts-keyring
<a id="__codelineno-1-3" name="__codelineno-1-3" href="http://localhost:8000/uv/guides/integration/alternative-indexes/#__codelineno-1-3"></a>
<a id="__codelineno-1-4" name="__codelineno-1-4" href="http://localhost:8000/uv/guides/integration/alternative-indexes/#__codelineno-1-4"></a><span class="gp"># </span>Enable<span class="w"> </span>keyring<span class="w"> </span>authentication
<a id="__codelineno-1-5" name="__codelineno-1-5" href="http://localhost:8000/uv/guides/integration/alternative-indexes/#__codelineno-1-5"></a><span class="gp">$ </span><span class="nb">export</span><span class="w"> </span><span class="nv">UV_KEYRING_PROVIDER</span><span class="o">=</span>subprocess
<a id="__codelineno-1-6" name="__codelineno-1-6" href="http://localhost:8000/uv/guides/integration/alternative-indexes/#__codelineno-1-6"></a>
<a id="__codelineno-1-7" name="__codelineno-1-7" href="http://localhost:8000/uv/guides/integration/alternative-indexes/#__codelineno-1-7"></a><span class="gp"># </span>Configure<span class="w"> </span>the<span class="w"> </span>index<span class="w"> </span>URL<span class="w"> </span>with<span class="w"> </span>the<span class="w"> </span>username
<a id="__codelineno-1-8" name="__codelineno-1-8" href="http://localhost:8000/uv/guides/integration/alternative-indexes/#__codelineno-1-8"></a><span class="gp">$ </span><span class="nb">export</span><span class="w"> </span><span class="nv">UV_EXTRA_INDEX_URL</span><span class="o">=</span>https://VssSessionToken@pkgs.dev.azure.com/<span class="o">{</span>organisation<span class="o">}</span>/<span class="o">{</span>project<span class="o">}</span>/_packaging/<span class="o">{</span>feedName<span class="o">}</span>/pypi/simple/
</code>

And it shows that the # symbol has the gp classname, which could cause issues if copied, as the # would be ignored!

@zanieb
Copy link
Member Author

zanieb commented Aug 2, 2024

😭 that's tragic.

@eth3lbert
Copy link
Contributor

Perhaps adding a note to STYLE.md? Alternatively, modify the copy logic to strictly ignore just $, not all go or gp classes.

@zanieb zanieb marked this pull request as ready for review August 3, 2024 13:41
@zanieb zanieb merged commit 44a6dbf into main Aug 3, 2024
46 checks passed
@zanieb zanieb deleted the zb/docs-v branch August 3, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants