Respect malformed .dist-info directories in tool installs
#5756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
python-babel/babel#1110 fixed the original issue. While inconvenient, I personally think that respecting malformed |
|
I think it's arguably standards-incompliant to reject non-normalized dist-info directories. |
|
Putting this behavior behind a flag could be beneficial in terms of prevention of malicious typo-squatting. Or maybe display a warning say more or less "The .dist-info is malformed. Be careful it might be malicious. If the package is legit please raise an issue to the authors/maintainers" ? |
|
To be clear, we do error if the normalized filenames don't match. We just don't require that the name on the directory is normalized already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5749.