Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reusing incompatible distributions across lock and sync #5845

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Aug 7, 2024

Summary

We need to avoid using incompatible versions for build dependencies that are also part of the resolved
environment. This is a very subtle issue, but: when locking, we don't enforce platform
compatibility. So, if we reuse the resolver state to install, and the install itself has to
preform a resolution (e.g., for the build dependencies of a source distribution), that
resolution may choose incompatible versions.

The key property here is that there's a shared package between the build dependencies and the
project dependencies.

Closes #5836.

@charliermarsh charliermarsh force-pushed the charlie/debug branch 4 times, most recently from b54eda3 to 42cba53 Compare August 7, 2024 00:41
Copy link

codspeed-hq bot commented Aug 7, 2024

CodSpeed Performance Report

Merging #5845 will not alter performance

Comparing charlie/debug (910b5dd) with main (f3cc8e4)

Summary

✅ 13 untouched benchmarks

@charliermarsh charliermarsh added the bug Something isn't working label Aug 7, 2024
@charliermarsh charliermarsh changed the title Debug environment for NumPy mis-install Avoid reusing incompatible distributions across lock and sync Aug 7, 2024
@charliermarsh charliermarsh marked this pull request as ready for review August 7, 2024 00:42
@charliermarsh
Copy link
Member Author

This is fixable but require some work in the resolver.

(That performance regression isn't real, it's from me adding a bunch of debug logging.)

@charliermarsh charliermarsh enabled auto-merge (squash) August 7, 2024 00:54
@charliermarsh charliermarsh merged commit cccb682 into main Aug 7, 2024
57 checks passed
@charliermarsh charliermarsh deleted the charlie/debug branch August 7, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv sync reports selecting incorrect arch for numpy wheel
1 participant